Blacklist OMX.SEC.mp3.dec and OMX.brcm.audio.mp3.decoder on Samsung devices

[mseroczynski]

Few confirmed fixes addressing #4519

These devices list below codecs (in this order):
OMX.SEC.mp3.dec
OMX.brcm.audio.mp3.decoder
OMX.google.mp3.decoder

Out of this list only OMX.google.mp3.decoder is working properly.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[mseroczynski]

I signed it!

[googlebot]

CLAs look good, thanks!

[ojw28]

Presumably each device has one of these decoders or the other. Can the code be structured to reflect this?

[ojw28]

Oh right, I read the change description and you're saying these devices really do have both of these (and the Google one). Is that definitely true for all of the referenced devices? If so then respond here and otherwise ignore the comment. Thanks!

[ojw28]

Looking at this more, I don't think it is true that all of these devices can have both of these decoders. "OMX.brcm" is probably Broadcom, but I think only two of these devices have Broadcom chipsets (SM-G350 and GT-I9152). I'd like for the code to accurately reflect what decoders are present on each device.

[mseroczynski]

Thank you for catching this out. I am 100% sure about (SM-G350, GT-I9152 and also GT-S7580) because I own psysical devices and debugged on all three them. As you pointed out, other devices (SM-T231, GT-I9152, GT-P5220) were just an assumption of similarity. I've corrected the PR to meet your suggestions and looking forward for round two of review.

PS: Correct me if I'm wrong but I think these codecs should be just somehow prioritized (not just Collections.singletonList(decoderInfos.get(0))) - I thought of this solution as a temporary fix that will be replaced somewhere in the future, as the list of if's may/will continue growing forever with current approach.

[ojw28]

I think this one belongs in the block above. It's not a broadcom based device.

[mseroczynski]

Overlooked! Swapping GT-I9515 with GT-I9152

[ojw28]

I'm surprised the GT-I9152 isn't in the block below, given this one is a broadcom based device.