Skip to content

Conversation

@ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Apr 13, 2021

Added path to generate_project.sh

@ncooke3 ncooke3 added the documentation Improvements or additions to documentation label Apr 13, 2021
@ncooke3 ncooke3 requested a review from paulb777 April 13, 2021 15:16
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now., but I never use this script and we might want to align this more directly with the Firebase and GoogleUtilities workflows.

@ncooke3
Copy link
Member Author

ncooke3 commented Apr 13, 2021

This is fine for now., but I never use this script and we might want to align this more directly with the Firebase and GoogleUtilities workflows.

@paulb777 Gotcha, I was following directions under the To develop header. Do you follow what's outlined under the Development header? If so, I could remove the To develop if that makes things more clear.

@google-oss-bot
Copy link

Coverage Report

Affected SDKs

No changes between base commit (369716b) and head commit (32d51d6).

Test Logs

@paulb777
Copy link
Member

Yep - I follow https://github.com/google/GoogleDataTransport#Development.

@ncooke3 ncooke3 merged commit e844aa8 into main Apr 13, 2021
@ncooke3 ncooke3 deleted the nc/docs-update branch April 13, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants