Add defaults for easier button instantiation#118
Merged
Conversation
Contributor
|
For setting style and scheme properties, should we consider using a pattern similar to that of the Button view with its buttonStyle instance method? |
Collaborator
Author
|
@petea can you elaborate on your question regarding This is set on the button here. |
petea
approved these changes
May 3, 2022
Contributor
petea
left a comment
petea
left a comment
There was a problem hiding this comment.
Much easier to configure now.
Separately, at some point, we might want to think about adding a button configurator view to the Swift sample similar to the Objc sample. This would help with exploration and testing.
Marking the vm public will allow users of the convenience init providing params for scheme, style, and state to modify the button's appearance after initialization.
mdmathias
force-pushed
the
mdmathias/swiftui-button-defaults
branch
from
ed034d2 to
c508ec2
Compare
Collaborator
Author
|
Added a new issue to track the addition of some way to update the button's appearance in the sample app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds default values to the initializers for
GoogleSignInButtonViewModelandGoogleSignInButtonto facilitate easier instantiation.