Skip to content

Add fake for GIDProfileDataFetcher #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Alex-4-Git merged 16 commits into from
Jan 17, 2023
Merged

Add fake for GIDProfileDataFetcher #279

Alex-4-Git merged 16 commits into from
Jan 17, 2023

Conversation

@Alex-4-Git
Copy link
Contributor

@Alex-4-Git Alex-4-Git commented Jan 3, 2023 •
edited
Loading

Add the class GIDFakeProfileDataFetcher conforming to the protocol GIDProfileDataFetcher.
Use this fake to replace mock in GIDSignInTest.

@Alex-4-Git Alex-4-Git requested a review from petea January 6, 2023 18:00
@Alex-4-Git Alex-4-Git marked this pull request as ready for review January 6, 2023 18:00
@Alex-4-Git
Move the new GIDProfileData initializer to GIDProfileDataFetcher
3c9e883 
The profile data items in the ID token and UserInfo endpoint response share keys so we decide to put them together in GIDProfileDataFetcher.
@Alex-4-Git
Merge branch 'pin-GIDProfileDataFetcher-new' into pin-GIDProfileDataF…
ec79d8f 
…etcher-fake
@Alex-4-Git
Add the fake for new method in GIDProfileDataFetcher.
163ab52
@Alex-4-Git Alex-4-Git marked this pull request as draft January 9, 2023 21:58
@Alex-4-Git Alex-4-Git force-pushed the pin-GIDProfileDataFetcher-fake branch from 5b51b9c to 91e4cb1 Compare January 11, 2023 21:09
@Alex-4-Git Alex-4-Git marked this pull request as ready for review January 11, 2023 21:24
@Alex-4-Git Alex-4-Git force-pushed the pin-GIDProfileDataFetcher-fake branch from 3fa5644 to 4da55e7 Compare January 11, 2023 21:24
@Alex-4-Git Alex-4-Git changed the title Add fake for GIDProfileDataFetcher. Add fake for GIDProfileDataFetcher Jan 11, 2023
petea
petea approved these changes Jan 14, 2023
View reviewed changes
@Alex-4-Git Alex-4-Git merged commit e95e502 into refactorGSI Jan 17, 2023
@Alex-4-Git Alex-4-Git deleted the pin-GIDProfileDataFetcher-fake branch January 17, 2023 18:45
@Alex-4-Git Alex-4-Git restored the pin-GIDProfileDataFetcher-fake branch January 17, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@petea petea petea approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Alex-4-Git @petea