Skip to content

Throw an exception if verified age scope is passed in sign-in request through the add scopes flow.#473

Merged
brnnmrls merged 13 commits intobriannamorales/vwg-flowfrom
briannamorales/testValidScopes
Sep 11, 2024
Merged

Throw an exception if verified age scope is passed in sign-in request through the add scopes flow.#473
brnnmrls merged 13 commits intobriannamorales/vwg-flowfrom
briannamorales/testValidScopes

Conversation

@brnnmrls
Copy link
Copy Markdown
Member

@brnnmrls brnnmrls commented Sep 4, 2024

If a developer passes verification age scope to addScopes method, this results in an error (invalid_request). Instead of having the developer run through documentation and figure out why it errors, we'll throw an exception to let the developer know to use GIDVerifyAccountDetail instead.

@brnnmrls brnnmrls self-assigned this Sep 4, 2024
@brnnmrls brnnmrls requested a review from mdmathias September 4, 2024 17:43
@brnnmrls brnnmrls marked this pull request as ready for review September 4, 2024 17:43
Comment thread GoogleSignIn/Sources/GIDSignIn.m Outdated
Comment thread GoogleSignIn/Sources/GIDSignIn.m Outdated
Comment thread GoogleSignIn/Sources/GIDSignIn.m Outdated
@brnnmrls brnnmrls requested a review from mdmathias September 5, 2024 23:31
Comment thread GoogleSignIn/Sources/GIDSignIn.m Outdated
Comment thread GoogleSignIn/Sources/GIDSignIn.m Outdated
@brnnmrls brnnmrls requested a review from mdmathias September 9, 2024 21:27
Comment thread GoogleSignIn/Sources/GIDRestrictedScopesRegistry.h Outdated
Comment thread GoogleSignIn/Sources/GIDRestrictedScopesRegistry.m Outdated
Comment thread GoogleSignIn/Sources/GIDSignIn.m Outdated
Comment thread GoogleSignIn/Sources/GIDSignIn.m Outdated
Comment thread GoogleSignIn/Sources/GIDSignIn.m Outdated
Comment thread GoogleSignIn/Tests/Unit/GIDRestrictedScopesRegistryTest.m Outdated
@brnnmrls brnnmrls requested a review from mdmathias September 10, 2024 16:28
Comment thread GoogleSignIn/Sources/GIDSignIn.m Outdated
@brnnmrls brnnmrls requested a review from mdmathias September 10, 2024 18:50
@brnnmrls brnnmrls merged commit ae6faa9 into briannamorales/vwg-flow Sep 11, 2024
@brnnmrls brnnmrls deleted the briannamorales/testValidScopes branch September 11, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants