Fix sign-in completion after interrupted authentication session#601
Open
ademirev wants to merge 1 commit into
Open
Fix sign-in completion after interrupted authentication session#601ademirev wants to merge 1 commit into
ademirev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #578
ASWebAuthenticationSessioncan be dismissed after device lock/backgrounding without AppAuth invoking its callback, leavingGIDSignInCompletionpending.This observes app lifecycle during interactive iOS sign-in and cancels the still-pending AppAuth flow after the app returns active if the flow had entered the background and has not completed. The cancellation goes through AppAuth's existing session cancel path, preserving the existing mapping to
kGIDSignInErrorCodeCanceled.Testing:
DEVELOPER_DIR=/Applications/Xcode.app/Contents/Developer xcodebuild -scheme GoogleSignIn-Package -sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPhone 16,OS=18.5' test -only-testing:GoogleSignIn-UnitTests/GIDSignInTestDEVELOPER_DIR=/Applications/Xcode.app/Contents/Developer xcodebuild -scheme GoogleSignIn-Package -sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPhone 16,OS=18.5' build-for-testingDEVELOPER_DIR=/Applications/Xcode.app/Contents/Developer xcodebuild -scheme GoogleSignIn-Package -sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPhone 16,OS=18.5' test-without-buildingDEVELOPER_DIR=/Applications/Xcode.app/Contents/Developer xcodebuild -scheme GoogleSignIn-Package -sdk macosx -destination 'platform=macOS,arch=arm64' build-for-testingDEVELOPER_DIR=/Applications/Xcode.app/Contents/Developer xcodebuild -scheme GoogleSignIn-Package -sdk macosx -destination 'platform=macOS,arch=arm64' test-without-buildinggit diff --check