Revert the MPU hack by splitting the store in 2#380
Merged
ia0 merged 2 commits intogoogle:developfrom Sep 16, 2021
Merged
Conversation
kaczmarczyck
approved these changes
Sep 15, 2021
Collaborator
kaczmarczyck
left a comment
There was a problem hiding this comment.
The only downside I see is that we have a limit of 8 regions, and STORAGE_LOCATIONS will need 5 of them. But from the logs I've seen so far, this should still be okay.
If we need to, we could make the new layout with upgrades a breaking change, and use either 16 or 32 pages, if latency allows.
Member
Author
|
Oh I see, I didn't consider this issue that we are limited to 8 regions. But we should still be fine right?
|
Collaborator
|
Yes, absolutely. My test runs with upgradability definitely had open regions. Just wanted to bring it to attention. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Essentially reverts kernel/src/process.rs to its state before moving the NUM_PAGES configuration in the board rather than the app.