Skip to content

Revert the MPU hack by splitting the store in 2#380

Merged
ia0 merged 2 commits intogoogle:developfrom
ia0:unhack_mpu
Sep 16, 2021
Merged

Revert the MPU hack by splitting the store in 2#380
ia0 merged 2 commits intogoogle:developfrom
ia0:unhack_mpu

Conversation

@ia0
Copy link
Copy Markdown
Member

@ia0 ia0 commented Sep 15, 2021

Essentially reverts kernel/src/process.rs to its state before moving the NUM_PAGES configuration in the board rather than the app.

@ia0 ia0 requested a review from kaczmarczyck September 15, 2021 17:39
@google-cla google-cla bot added the cla: yes label Sep 15, 2021
@coveralls
Copy link
Copy Markdown

coveralls commented Sep 15, 2021

Coverage Status

Coverage remained the same at 42.458% when pulling e0693e4 on ia0:unhack_mpu into 596b478 on google:develop.

Copy link
Copy Markdown
Collaborator

@kaczmarczyck kaczmarczyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only downside I see is that we have a limit of 8 regions, and STORAGE_LOCATIONS will need 5 of them. But from the logs I've seen so far, this should still be okay.
If we need to, we could make the new layout with upgrades a breaking change, and use either 16 or 32 pages, if latency allows.

@ia0
Copy link
Copy Markdown
Member Author

ia0 commented Sep 15, 2021

Oh I see, I didn't consider this issue that we are limited to 8 regions. But we should still be fine right?

  • Region 0 is for the RAM.
  • Region 1 is for the flash.
  • Region 2 and 3 are for the store.
  • Region 4, 5, and 6 are for the upgrade mechanism (2 partitions + 1 metadata).

@kaczmarczyck
Copy link
Copy Markdown
Collaborator

Yes, absolutely. My test runs with upgradability definitely had open regions. Just wanted to bring it to attention.

@ia0 ia0 merged commit 18ba436 into google:develop Sep 16, 2021
@ia0 ia0 deleted the unhack_mpu branch September 16, 2021 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants