New boards with layouts for dual partition setups#387
Merged
kaczmarczyck merged 6 commits intogoogle:developfrom Oct 6, 2021
Merged
New boards with layouts for dual partition setups#387kaczmarczyck merged 6 commits intogoogle:developfrom
kaczmarczyck merged 6 commits intogoogle:developfrom
Conversation
jmichelp
reviewed
Oct 1, 2021
Collaborator
jmichelp
left a comment
There was a problem hiding this comment.
That's a lot of code being duplicated.
I wonder if we couldn't do better by passing the arguments through env variables and tweak the build.rs and the main.rs to go back to fewer boards (devkit, dongle, mdk).
Collaborator
Author
|
I reused the |
jmichelp
reviewed
Oct 6, 2021
jmichelp
approved these changes
Oct 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the dev board layouts for a setup with a bootloader and 2 partitions.
Most of the changes in this PR are slightly changed copies of existing code. The
nrf52840_layout_*.ldfiles are similar to the existingnrf52840_layout.ld, and the boards are similar to the non-partitioned variant, too. All changes from the existing dev board definition to the new ones are documented in the respectiveREADME.md.Outside of boards and layouts, this biggest change is in the deploy script. Changes include:
I'm not sure about the less redundant definitions of
OpenSKBoard, please let me know what you think, I can revert them if you like. To have the boards running, you need to also flash the matching bootloader. Other than that, the deployment didn't change, just specify the board name.