Skip to content

New boards with layouts for dual partition setups#387

Merged
kaczmarczyck merged 6 commits intogoogle:developfrom
kaczmarczyck:submit-upgrade
Oct 6, 2021
Merged

New boards with layouts for dual partition setups#387
kaczmarczyck merged 6 commits intogoogle:developfrom
kaczmarczyck:submit-upgrade

Conversation

@kaczmarczyck
Copy link
Collaborator

Adds the dev board layouts for a setup with a bootloader and 2 partitions.

Most of the changes in this PR are slightly changed copies of existing code. The nrf52840_layout_*.ld files are similar to the existing nrf52840_layout.ld, and the boards are similar to the non-partitioned variant, too. All changes from the existing dev board definition to the new ones are documented in the respective README.md.

Outside of boards and layouts, this biggest change is in the deploy script. Changes include:

  • some refactoring
  • paddings are optional
  • new metadata writer

I'm not sure about the less redundant definitions of OpenSKBoard, please let me know what you think, I can revert them if you like. To have the boards running, you need to also flash the matching bootloader. Other than that, the deployment didn't change, just specify the board name.

@kaczmarczyck kaczmarczyck self-assigned this Sep 28, 2021
@google-cla google-cla bot added the cla: yes label Sep 28, 2021
@coveralls
Copy link

coveralls commented Sep 28, 2021

Coverage Status

Coverage increased (+0.07%) to 42.059% when pulling 3a070a7 on kaczmarczyck:submit-upgrade into d085d54 on google:develop.

Copy link
Collaborator

@jmichelp jmichelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of code being duplicated.
I wonder if we couldn't do better by passing the arguments through env variables and tweak the build.rs and the main.rs to go back to fewer boards (devkit, dongle, mdk).

@kaczmarczyck
Copy link
Collaborator Author

I reused the src/ from nrf52840dk_opensk. Now all 3 dev board definitions load the STORAGE_LOCATIONS from a generated locations.rs. I'm not sure about the benefit of completely removing board definitions. The cleanest solution for 3 different layouts should be 3 different layout.ld files. WDYT?

@kaczmarczyck kaczmarczyck requested a review from jmichelp October 5, 2021 13:47
@kaczmarczyck kaczmarczyck requested a review from jmichelp October 6, 2021 15:32
@kaczmarczyck kaczmarczyck merged commit 9b780ef into google:develop Oct 6, 2021
@kaczmarczyck kaczmarczyck deleted the submit-upgrade branch October 6, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants