Forward desktop test fixes#419
Merged
kaczmarczyck merged 3 commits intogoogle:developfrom Nov 30, 2021
Merged
Conversation
kaczmarczyck
force-pushed
the
forward-clippy-fix
branch
from
2dd6613 to
0c5350b
Compare
ia0
previously approved these changes
Nov 30, 2021
ia0
approved these changes
Nov 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes clippy warnings of nightly compilers until 2021-11-25. This helps users who experiment with versions newer than our current 2021-03-25, and also can't hurt out style. Additionally, the second commit is a fix for
run_desktop_tests.shthat sometimes fails with a similar problem as #407.I decided to ignore some of the clippy warnings, instead of renaming the enum variants. This is to stay closer to names in the specification, e.g. command "authenticatorMakeCredential".