Skip to content

Adds SHA256 Cryptocell code to bootloader#432

Merged
kaczmarczyck merged 3 commits intogoogle:developfrom
kaczmarczyck:bootloader
Mar 4, 2022
Merged

Adds SHA256 Cryptocell code to bootloader#432
kaczmarczyck merged 3 commits intogoogle:developfrom
kaczmarczyck:bootloader

Conversation

@kaczmarczyck
Copy link
Copy Markdown
Collaborator

The last piece to make the bootloader actually work. Advantage of a hardware SHA256 is the much faster boot time.

@kaczmarczyck kaczmarczyck requested a review from jmichelp March 3, 2022 22:25
@kaczmarczyck kaczmarczyck self-assigned this Mar 3, 2022
Copy link
Copy Markdown
Collaborator

@jmichelp jmichelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we may need the Cryptocell code also in Tock, I wonder if this wouldn't make sense to make it a separate crate that we could import in both the bootloader and the kernel. Otherwise we'll end up with code duplication and different kinds of API to compute hashes.

@kaczmarczyck
Copy link
Copy Markdown
Collaborator Author

Question is if you want the new crate now or submit and put the work in when / if we submit it to Tock?

This PR is simpler than what I think you had in mind for Tock, i.e. it's API doesn't allow concurrent calls. So I don't know if a simply move to a new crate would actually be that useful?

@kaczmarczyck kaczmarczyck requested a review from jmichelp March 4, 2022 14:59
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 4, 2022

Coverage Status

Coverage remained the same at 90.671% when pulling 5e30a47 on kaczmarczyck:bootloader into 91ba2c3 on google:develop.

@jmichelp
Copy link
Copy Markdown
Collaborator

jmichelp commented Mar 4, 2022

We can merge it as-is at the moment to get the feature out.
And let's align with @ia0 to make it a separate crate that can bootstrap the work around hardware crypto support.

@ia0
Copy link
Copy Markdown
Member

ia0 commented Mar 4, 2022

And let's align with @ia0 to make it a separate crate that can bootstrap the work around hardware crypto support.

Ack! (I don't have any ideas yet, and that might be related to ctap as a library too, so should definitely be in our radar).

@kaczmarczyck kaczmarczyck merged commit d1f425c into google:develop Mar 4, 2022
@kaczmarczyck
Copy link
Copy Markdown
Collaborator Author

Thanks!

@kaczmarczyck kaczmarczyck deleted the bootloader branch March 4, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants