Adds SHA256 Cryptocell code to bootloader#432
Conversation
jmichelp
left a comment
There was a problem hiding this comment.
As we may need the Cryptocell code also in Tock, I wonder if this wouldn't make sense to make it a separate crate that we could import in both the bootloader and the kernel. Otherwise we'll end up with code duplication and different kinds of API to compute hashes.
|
Question is if you want the new crate now or submit and put the work in when / if we submit it to Tock? This PR is simpler than what I think you had in mind for Tock, i.e. it's API doesn't allow concurrent calls. So I don't know if a simply move to a new crate would actually be that useful? |
|
We can merge it as-is at the moment to get the feature out. |
Ack! (I don't have any ideas yet, and that might be related to ctap as a library too, so should definitely be in our radar). |
|
Thanks! |
The last piece to make the bootloader actually work. Advantage of a hardware SHA256 is the much faster boot time.