Merged
Conversation
ia0
previously approved these changes
Mar 7, 2022
ia0
previously approved these changes
Mar 7, 2022
c551576 to
5ff5f94
Compare
ia0
approved these changes
Mar 7, 2022
Collaborator
Author
|
The fuzzing check passes locally, therefore I'll submit and fix that separately. |
Member
Note also that it's the CIFuzz job that's failing, not the "Cargo fuzz build" one, so it's working locally even for GitHub. It's the docker setup the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has 2 commits. The first
CtapHidCommandenumMessages with a newprocess_messagethat contains core logicAfter this bigger cleanup, the second commit actually works on the goal of this PR: To have an API that separates all CTAP logic, and is the first step on the road to a pure HID library. It does so without changing the API. The plan is to move
process_hid_packet(which is now very short) out of the library, and have two instances with differentprocess_messagefunctions later. This will also allow removing thewink_permissioneventually.If you rather review in 2 PRs, I'll split the second commit to a new PR (or I could also split commit 1 if necessary). In this case, consider this the overview.
Plan for future submissions is:
hid/mod.rs, the new interface is much more test friendly.