Skip to content

Move remaining customizations to new file#473

Merged
kaczmarczyck merged 2 commits intogoogle:developfrom
hcyang-google:customization
Apr 28, 2022
Merged

Move remaining customizations to new file#473
kaczmarczyck merged 2 commits intogoogle:developfrom
hcyang-google:customization

Conversation

@hcyang-google
Copy link
Copy Markdown
Collaborator

@hcyang-google hcyang-google commented Apr 28, 2022

Three modifications to the logic because TryFrom can't access env that we've discussed:

  1. exclude_list doesn't limit length to max credentials count in list anymore
  2. allow_list doesn't limit length to max credentials count in list anymore
  3. Check of MAX_LARGE_BLOB_ARRAY_SIZE moved to large blob command processing

@hcyang-google hcyang-google changed the base branch from stable to develop April 28, 2022 08:24
@hcyang-google hcyang-google changed the title Customization Move remaining customizations to new file Apr 28, 2022
@kaczmarczyck kaczmarczyck self-requested a review April 28, 2022 08:50
@kaczmarczyck kaczmarczyck reopened this Apr 28, 2022
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 28, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 88.812% when pulling dbda897 on hcyang-google:customization into 4782d7e on google:develop.

@kaczmarczyck kaczmarczyck merged commit a0e11bd into google:develop Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaczmarczyck kaczmarczyck kaczmarczyck approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hcyang-google @coveralls @kaczmarczyck