Merged
Conversation
kaczmarczyck
reviewed
Jun 3, 2022
Collaborator
kaczmarczyck
left a comment
There was a problem hiding this comment.
I think I like this a bit better than #486. Might be a personal preference, but a quick comment on the non-intuitive use of Cow could be nice (we don't actually care about the writing part).
I find the binary size increases of both PRs surprising (in relation, at least). Would be great if we could check somehow if it's variance, but I don't see how.
Member
Author
|
Given that in #488 the binary size didn't increase while adding code, I'm assuming this PR is rather at the bottom of the current slot of added size. |
kaczmarczyck
approved these changes
Jun 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #486 but takes the opposite approach:
This is preferable to #486 because:
If we ever need to support
embedded-storagetrait, then we could add anOption<&mut [u8]>argument to be used and returned in theCow<[u8]>. This would avoid allocation and copy. But since we don't have this need, we don't do it.