Skip to content

Fixed proc-macro2 version#550

Merged
kaczmarczyck merged 5 commits intogoogle:developfrom
kaczmarczyck:fix-proc-macro2
Sep 27, 2022
Merged

Fixed proc-macro2 version#550
kaczmarczyck merged 5 commits intogoogle:developfrom
kaczmarczyck:fix-proc-macro2

Conversation

@kaczmarczyck
Copy link
Collaborator

Fixes #549

Pins the version for our proc-macro2 dependency.

ia0
ia0 previously approved these changes Sep 26, 2022
sophiel-meow
sophiel-meow previously approved these changes Sep 26, 2022
Copy link
Contributor

@sophiel-meow sophiel-meow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

@kaczmarczyck kaczmarczyck dismissed stale reviews from sophiel-meow and ia0 via 9f88737 September 27, 2022 06:39
@kaczmarczyck
Copy link
Collaborator Author

I added the missing Cargo.lock, now only the binary size report failing. That is expected as it tries to build without the PR.
Thanks @junasaka for confirming.
Thanks @ia0 for review.

@kaczmarczyck kaczmarczyck requested a review from ia0 September 27, 2022 06:51
@kaczmarczyck kaczmarczyck merged commit 6610a29 into google:develop Sep 27, 2022
@kaczmarczyck kaczmarczyck deleted the fix-proc-macro2 branch September 27, 2022 08:12
@kaczmarczyck kaczmarczyck mentioned this pull request Oct 10, 2022
hcyang-google pushed a commit to hcyang-google/OpenSK that referenced this pull request Oct 25, 2022
* fixes proc-macro2 in dependencies

* adds missing locked versions, and a verbose print for cargo check

* commits Cargo.lock files

* removes unnecessary Cargo.lock entries

* adds missing Cargo.lock
hcyang-google added a commit that referenced this pull request Oct 26, 2022
* Add storage test cases for multi-PIN

* Fixed proc-macro2 version (#550)

* fixes proc-macro2 in dependencies

* adds missing locked versions, and a verbose print for cargo check

* commits Cargo.lock files

* removes unnecessary Cargo.lock entries

* adds missing Cargo.lock

Co-authored-by: kaczmarczyck <43844792+kaczmarczyck@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants