Skip to content

Renames the feature with_ctap1 to ctap1#775

Merged
kaczmarczyck merged 2 commits intogoogle:developfrom
kaczmarczyck:rename
May 5, 2026
Merged

Renames the feature with_ctap1 to ctap1#775
kaczmarczyck merged 2 commits intogoogle:developfrom
kaczmarczyck:rename

Conversation

@kaczmarczyck
Copy link
Copy Markdown
Collaborator

The old feature name goes against the Rust naming convention.

Do not include words in the name of a Cargo feature that convey zero meaning, as in use-abc or with-abc. Name the feature abc directly.

https://rust-lang.github.io/api-guidelines/naming.html#c-feature

@kaczmarczyck kaczmarczyck requested a review from ia0 May 5, 2026 16:29
@kaczmarczyck kaczmarczyck self-assigned this May 5, 2026
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 97.262%. remained the same — kaczmarczyck:rename into google:develop

@kaczmarczyck kaczmarczyck merged commit 156c94a into google:develop May 5, 2026
7 checks passed
@kaczmarczyck kaczmarczyck deleted the rename branch May 5, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants