Fix U2F UP not timing out#778
Merged
Merged
Conversation
There was 2 issues preventing the U2F UP from timing out: 1. There was no timeout waiting for packets while U2F UP is on. 2. When timing out for packets the U2F UP logic was skipped. The fixes are: 1. A timeout of 1 second is used when U2F UP is on. 2. We execute the rest of the loop body (except for packet processing).
|
coverage: 97.274%. remained the same — ia0:fix-applet into google:develop |
kaczmarczyck
previously approved these changes
May 28, 2026
kaczmarczyck
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was 2 issues preventing the U2F UP from timing out:
The fixes are:
This needs the
impl Drop for Touchof #777 to actually fix the blinking.