Skip to content

Close code-doc parity gaps for BigQuery Agent Analytics plugin#1689

Merged
koverholt merged 2 commits intogoogle:mainfrom
caohy1988:bqaa-doc-code-parity
Apr 27, 2026
Merged

Close code-doc parity gaps for BigQuery Agent Analytics plugin#1689
koverholt merged 2 commits intogoogle:mainfrom
caohy1988:bqaa-doc-code-parity

Conversation

@caohy1988
Copy link
Copy Markdown
Contributor

@caohy1988 caohy1988 commented Apr 27, 2026

Summary

Reviewed bigquery_agent_analytics_plugin.py at adk-python@7de5bc5 (2026-04-25) against the current docs and closed the following gaps:

  • A2A_INTERACTION event type + view (High): Add A2A_INTERACTION event documentation, v_a2a_interaction view to the views table, and update the auto-created view count from 15 → 16.
  • TRANSFER_A2A tool origin (High): Add TRANSFER_A2A to the tool provenance table — classifies TransferToAgentTool calls that transfer to a RemoteA2aAgent at call-level.
  • v_llm_response cache columns (Medium): Add usage_cached_tokens (INT64), cache_metadata (JSON), and context_cache_hit_rate (FLOAT64) to the view columns table so users can discover cache-hit analysis from the view.
  • Constructor credentials parameter (Medium): Document all BigQueryAgentAnalyticsPlugin constructor parameters, including credentials for service-account, impersonated, or cross-project auth setups.
  • Multiprocessing / fork safety (Low): Add guidance on fork-awareness (GRPC_ENABLE_FORK_SUPPORT, os.register_at_fork), the spawn recommendation, and Gunicorn deployment patterns.

Intentionally not documented: EventData dataclass (internal to _log_event, not public API).

Test plan

  • Verify the views table renders correctly with all 16 rows
  • Verify the tool origins table renders correctly with the new TRANSFER_A2A row
  • Verify the A2A Interaction Events section renders correctly under Event types
  • Verify the constructor parameters list renders correctly under Configuration options
  • Verify the Multiprocessing section renders correctly before Feedback

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 27, 2026

Deploy Preview for adk-docs-preview ready!

Name Link
🔨 Latest commit 41f08d0
🔍 Latest deploy log https://app.netlify.com/projects/adk-docs-preview/deploys/69efa43c52c2b7000892e05e
😎 Deploy Preview https://deploy-preview-1689--adk-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Apr 27, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@koverholt koverholt self-requested a review April 27, 2026 17:53
- Add A2A_INTERACTION event type, view (v_a2a_interaction), and docs section
- Add TRANSFER_A2A tool origin to provenance table
- Add cache_metadata, usage_cached_tokens, context_cache_hit_rate to
  v_llm_response view columns
- Document all BigQueryAgentAnalyticsPlugin constructor parameters
  including the credentials parameter for non-ADC auth
- Add multiprocessing/fork safety guidance (spawn recommendation,
  Gunicorn patterns)
- Update auto-created view count from 15 to 16

Reviewed against adk-python@7de5bc5 (2026-04-25).
@caohy1988 caohy1988 force-pushed the bqaa-doc-code-parity branch from 46a3917 to 9232b9b Compare April 27, 2026 18:00
Copy link
Copy Markdown
Collaborator

@koverholt koverholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates LGTM, and thanks for fixing the committer issue with Claude Code assisted commits since we cannot merge PRs with it as a coauthor - it will fail the CLA check. Merging.

@koverholt koverholt merged commit e156364 into google:main Apr 27, 2026
6 checks passed
koverholt pushed a commit to sabrenner/google-adk-docs that referenced this pull request Apr 28, 2026
…e#1689)

- Add A2A_INTERACTION event type, view (v_a2a_interaction), and docs section
- Add TRANSFER_A2A tool origin to provenance table
- Add cache_metadata, usage_cached_tokens, context_cache_hit_rate to
  v_llm_response view columns
- Document all BigQueryAgentAnalyticsPlugin constructor parameters
  including the credentials parameter for non-ADC auth
- Add multiprocessing/fork safety guidance (spawn recommendation,
  Gunicorn patterns)
- Update auto-created view count from 15 to 16

Reviewed against adk-python@7de5bc5 (2026-04-25).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants