Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the SkillToolset and associated tools (list_skills, load_skill, load_skill_resource) to enable agents to interact with specialized skills defined in structured directories. It includes example skills for grocery pricing and weather information. Key feedback includes correcting the Role in system instructions to avoid misinterpretation by the model, addressing code duplication in XML generation, and optimizing token usage by reconsidering the injection of all available skills into every request. Additionally, a memory limit is suggested for resource loading to prevent potential OOM issues.
SkillToolset encapsulates the Agent Skills feature. This toolset ensures agent is equipped with all the tools needed to use skills and is provided with proper instructions. What skill toolset enable agent to do: - List available skills. - Read instructions of the skills (by skill name). - Read specific resources of the skills (by resource path). Current implementation is very basic, e.g.: - There is no script execution support yet. - Skill activation is history-based: skill instructions and resources are provided to the llm as function call results in conversation history. - Every resource should be specifically mentioned in the SKILL.md file: the agent is unable to list resources available for the skills.
foxfrikses
force-pushed
the
skills-core-toolset
branch
from
abee7c0 to
176dda4
Compare
Reuse skilltoolset.SkillsToXML in skilltoolset. Reuse utils.AppendInstructions in skilltoolset. Enforce maximum resource size to prevent OOM.
dpasiukevich
previously approved these changes
Apr 17, 2026
dpasiukevich
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SkillToolset encapsulates the Agent Skills feature. This toolset ensures agent is equipped with all the tools needed to use skills and is provided with proper instructions.
What skill toolset enable agent to do:
Current implementation is very basic, e.g.: