feat: implement workflow connectivity validation to ensure all nodes are reachable from start#809
Merged
Merged
Conversation
hanorik
force-pushed
the
connect_validator
branch
2 times, most recently
from
839de78 to
26d4538
Compare
wolo-lab
requested changes
May 11, 2026
hanorik
force-pushed
the
connect_validator
branch
from
26d4538 to
5c985c8
Compare
hanorik
force-pushed
the
connect_validator
branch
from
5c985c8 to
c50c144
Compare
anFatum
approved these changes
May 15, 2026
…are reachable from start
hanorik
force-pushed
the
connect_validator
branch
from
c50c144 to
3a6b38a
Compare
hanorik
force-pushed
the
connect_validator
branch
from
6fa036f to
81411a2
Compare
wolo-lab
added a commit
that referenced
this pull request
May 16, 2026
…mpt/goimports CI lint job started failing after PR #809 introduced unformatted slice literals in validation_test.go and an unordered import group in graph_test.go. gofumpt and goimports flag both. Fix is purely formatting — no behaviour change.
wolo-lab
pushed a commit
that referenced
this pull request
May 18, 2026
…are reachable from start (#809)
wolo-lab
added a commit
that referenced
this pull request
May 18, 2026
…mpt/goimports CI lint job started failing after PR #809 introduced unformatted slice literals in validation_test.go and an unordered import group in graph_test.go. gofumpt and goimports flag both. Fix is purely formatting — no behaviour change.
wolo-lab
pushed a commit
that referenced
this pull request
May 25, 2026
…are reachable from start (#809)
wolo-lab
pushed a commit
that referenced
this pull request
Jun 2, 2026
…are reachable from start (#809)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces validation to ensure that all nodes in a workflow graph are reachable from the
Startnode. This prevents orphaned nodes that can never be executed, ensuring the graph is fully connected and valid.Key Changes:
validation.go: Added logic to traverse the workflow graph and verify that every registered node has at least one path leading to it from the start.workflow.go: Integrated the connectivity check into the workflow initialization/validation process.validation_test.goto cover valid connected graphs and invalid disconnected graphs.