A2A integration: Fix event conversion issues to align with A2A <-> ADK Go implementation#178
Merged
kalenkevich merged 3 commits intomainfrom Mar 6, 2026
Merged
A2A integration: Fix event conversion issues to align with A2A <-> ADK Go implementation#178kalenkevich merged 3 commits intomainfrom
kalenkevich merged 3 commits intomainfrom
Conversation
ishymko
approved these changes
Mar 5, 2026
995b27f to
2830e84
Compare
Collaborator
Author
|
Related to #189 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
Problem:
The codebase required better separation of concerns and more robust handling for A2A Events. There was a need for improved conversion logic and accurate handling of event metadata, long-running tool IDs, and function call/response IDs as it previously relied on function names for tool matching (which is a bug!).
Solution:
core/src/a2a/a2a_event.ts.core/src/a2a/event_converter_utils.tsto utilize the new event definitions and improved conversion logic betweenAdkEventandA2AEvent(handling tasks, messages, and artifact updates).core/src/a2a/part_converter_utils.tsto accurately handleidproperties forfunctionCallandfunctionResponseinstead of relying on function names for matching long-running tools.a2a_event_test.ts,event_converter_utils_test.ts,part_converter_utils_test.ts, andmetadata_converter_utils_test.tsto ensure full coverage and correct behavior.Testing Plan
Unit Tests:
All unit tests in
core/test/a2a/pass successfully.Manual End-to-End (E2E) Tests:
N/A - This is a refactoring and internal logic update covered by unit tests.
Checklist
Additional context
None