Add esbuild to bundle the source code#2
Merged
Conversation
cornellgit
reviewed
Aug 29, 2025
| "@google/genai": "^1.6.0", | ||
| "openapi-types": "^12.1.3", | ||
| "@opentelemetry/api": "^1.9.0" | ||
| "@opentelemetry/api": "^1.9.0", |
Collaborator
Author
There was a problem hiding this comment.
it just being sorted asc, I think it does that after each npm install your-dep. So maybe let's keep that
cornellgit
reviewed
Aug 29, 2025
| * Generates a random UUID. | ||
| */ | ||
| const UUID_MASK = 'xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx'; | ||
| export function randomUUID() { |
Collaborator
There was a problem hiding this comment.
not sure about this, recreating UUID is not a light weight task. fine to start with this, but we need better env based solutions.
cornellgit
reviewed
Aug 29, 2025
Collaborator
cornellgit
left a comment
cornellgit
left a comment
There was a problem hiding this comment.
test and ci fails, would be good to fix.
we need a more robust UUID solutions if we don't use lib. I still think shim is a good way to approach this.
kalenkevich
force-pushed
the
esbuild-support
branch
4 times, most recently
from
c8ae34e to
8cdc2f3
Compare
cornellgit
approved these changes
Aug 29, 2025
Collaborator
cornellgit
left a comment
cornellgit
left a comment
There was a problem hiding this comment.
would be good for barndon also to double check this.
Supported targets: node esm node cjs web esm Tested on: Web webpack Node esm mode (imports) Node cjs mode (require) Fix tests for CI crypto.randomUUID I found it messy to create shims (node + browser) just for randomUUID function. I would like to keep our own implementation for now. I can add shims support in follow up change.
kalenkevich
force-pushed
the
esbuild-support
branch
from
8cdc2f3 to
9abc793
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add esbuild to bundle the source code for different targets
Supported targets:
Tested on:
crypto.randomUUID
I found it messy to create shims (node + browser) just for
randomUUIDfunction. I would like to keep our own implementation for now. I can add shims support in follow up change.