fix: fix adk web ui source code serving path#309
Merged
Conversation
9 tasks
This was referenced Apr 28, 2026
ScottMansfield
approved these changes
Apr 28, 2026
Merged
nuthalapativarun
pushed a commit
to nuthalapativarun/adk-js
that referenced
this pull request
May 9, 2026
* fix: fix adk web ui source code serving path * fix: add integration test * updates * updates * fix: remove bundle from coe package during the packaging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
Problem:
CLI entrypoint was bundled and because of that file paths have been broken since the #245.
Solution:
Changed bundled version as entrypoint for ADK CLI to not bundled esm version of that. This ensures that relative path to the browser data will be handled correctly.
Testing Plan
Added integration test to test that ADK WEB is loaded correctly for 2 cases:
adk web ./folderCLI command.AdkApiServerfrom@google/adk-devtoolsManual End-to-End (E2E) Tests:
Please provide instructions on how to manually test your changes, including any necessary setup or configuration. Please provide logs or screenshots to help reviewers better understand the fix.
npm run buildin thedevdirectory to verify that the build completes successfully and the files are placed in the expected directory (./dist/browser).Checklist
Additional context
Add any other context or screenshots about the feature request here.
None.