Skip to content

fix: fix adk web ui source code serving path#309

Merged
kalenkevich merged 6 commits into
mainfrom
fix/webui_bug
Apr 28, 2026
Merged

fix: fix adk web ui source code serving path#309
kalenkevich merged 6 commits into
mainfrom
fix/webui_bug

Conversation

@kalenkevich
Copy link
Copy Markdown
Collaborator

@kalenkevich kalenkevich commented Apr 28, 2026

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

Problem:
CLI entrypoint was bundled and because of that file paths have been broken since the #245.

Solution:
Changed bundled version as entrypoint for ADK CLI to not bundled esm version of that. This ensures that relative path to the browser data will be handled correctly.

Testing Plan

Added integration test to test that ADK WEB is loaded correctly for 2 cases:

  • When using adk web ./folder CLI command.
  • When using AdkApiServer from @google/adk-devtools

Manual End-to-End (E2E) Tests:

Please provide instructions on how to manually test your changes, including any necessary setup or configuration. Please provide logs or screenshots to help reviewers better understand the fix.

  • Ran npm run build in the dev directory to verify that the build completes successfully and the files are placed in the expected directory (./dist/browser).

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas. (Simple cleanup, no comments needed).
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

None.

@kalenkevich kalenkevich merged commit b92c238 into main Apr 28, 2026
7 checks passed
@kalenkevich kalenkevich deleted the fix/webui_bug branch April 28, 2026 21:16
@kalenkevich kalenkevich mentioned this pull request Apr 28, 2026
nuthalapativarun pushed a commit to nuthalapativarun/adk-js that referenced this pull request May 9, 2026
* fix: fix adk web ui source code serving path

* fix: add integration test

* updates

* updates

* fix: remove bundle from coe package during the packaging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants