fix: set release-as at runtime instead of committing to config #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplify cut-release-branch to just create branch and trigger release-please - Move release-as configuration to release-please workflow at runtime - This avoids polluting main branch when merging back release changes - Update publish-pypi permissions to contents: write
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This was referenced Feb 7, 2026
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cut-release-branchto just create branch and trigger release-please (no file modifications)release-asconfiguration torelease-pleaseworkflow at runtime usingjqpublish-pypipermissions tocontents: writeProblem
Previously,
cut-release-branchcommittedrelease-asto the config file, which would get merged back to main and require cleanup.Solution
Set
release-asat runtime inrelease-please.ymlusingjq- the change is never committed, so it doesn't pollute any branch.