fix: do not use mutable objects for function argument defaults #289
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes usage of mutable defaults in a some methods. The usage of mutable defaults does not have any adverse impact currently since the object
initial_sessionis not updated in the methods as of now, but any change in the future may introduce bugs due to this and hence a good practice not to use mutable defaults and instead initialise the mutable object inside the function body.Why It’s Dangerous
For eg.
will print
To further see why it is bad, please see