docs: correct typo in conversion_utils.py #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
hangfei
reviewed
Apr 23, 2025
Collaborator
hangfei
left a comment
hangfei
left a comment
There was a problem hiding this comment.
please fix commit message(see check failures)
| This function transforms an ADK tool definition into its equivalent | ||
| representation in the MCP (Model Control Plane) system. | ||
| representation in the MCP (Model Context Protocol) system. |
Collaborator
There was a problem hiding this comment.
-> MCP (Model Context Protocol) representation
Collaborator
There was a problem hiding this comment.
Thanks. But Let's keep the original indentation.
Contributor
Author
|
updated commit message |
Quantisan
force-pushed
the
patch-2
branch
2 times, most recently
from
7e45607 to
38ce9d1
Compare
Quantisan
changed the title
Quantisan
force-pushed
the
patch-2
branch
2 times, most recently
from
379d475 to
6bdd19f
Compare
Collaborator
|
Could you use original indentation? |
Contributor
Author
updated |
hangfei
added
the
ready to pull
coder-aditi
pushed a commit
to coder-aditi/adk-python
that referenced
this pull request
Jul 2, 2025
* docs: correct typo in conversion_utils.py * docs: edited for conciseness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correcting MCP terminology in a docstring to avoid confusion