-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat(runners): Allow app_name to override app.name when both provided #3745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(runners): Allow app_name to override app.name when both provided #3745
Conversation
This change enables Agent Engine deployments to use App objects with event compaction and context caching configs while using the Agent Engine resource name for session operations, rather than App.name. - Allow app_name parameter to override app.name when both are provided - Still error when app and agent are both provided (prevents confusion) - Updated tests to reflect new behavior and added test for override case - Updateed documentation to clarify the new usage pattern This fixes the issue where App.name (a simple identifier) conflicts with Agent Engine's requirement for resource names in session creation. Related to issue google#3715
Summary of ChangesHello @sarojrout, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical limitation in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a useful enhancement to the Runner class, allowing app_name to override app.name when both are provided. This change is well-motivated, particularly for Agent Engine deployment scenarios. The implementation is clean, and the new behavior is covered by a dedicated unit test. The documentation has also been updated to reflect this change. My review found one minor issue: the Raises section in the __init__ docstring is now incomplete as it omits the case where plugins are provided with an app, which still raises a ValueError. I've provided a suggestion to correct this. Overall, this is a good change that improves the flexibility of the Runner.
- Update Raises section in Runner.__init__ docstring to mention plugins validation error when app is provided - Add warning filters to new tests to suppress deprecation warnings from setup_method that uses deprecated plugins parameter
|
Hi @sarojrout , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Your PR has been received by the team and is currently under review. We will provide feedback as soon as we have an update to share. |
|
Hi @wyf7107 , can you please review this. |
This change enables Agent Engine deployments to use App objects with event compaction and context caching configs while using the Agent Engine resource name for session operations, rather than App.name.
This fixes the issue where App.name (a simple identifier) conflicts with Agent Engine's requirement for resource names in session creation.
Related to issue #3715
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
If applicable, please follow the issue templates to provide as much detail as
possible.
Problem:
When deploying an agent to Agent Engine with event compaction and/or context caching enabled, users must wrap their agent in an
Appobject to configure these features. However, when theAppis passed toAdkAppand deployed, session creation fails because:App.nameis validated as a simple Python identifier (e.g.,"my_agent_name") viavalidate_app_name()"projects/123/locations/us-central1/reasoningEngines/456") or the reasoning engine IDAppobject is passed toAdkApp, the deployment storesApp.name(the simple identifier), but session creation later rejects it as invalidThis prevents users from deploying to Agent Engine with event compaction or context caching enabled.
Solution:
Allow the
app_nameparameter inRunner.__init__()to overrideapp.namewhen both are provided. This enables Agent Engine (and other deployment scenarios) to:Appobject to preserve event compaction and context caching configurationsapp.namewith the Agent Engine resource name for session operationsThe change is backward compatible: existing code that only provides
appcontinues to useapp.nameas before. The override only applies whenapp_nameis explicitly provided along withapp.Testing Plan
Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.
Unit Tests:
Updated existing test (
test_runner_init_raises_error_with_app_and_agent):app+app_name+agenterror to testing onlyapp+agenterrorappandagentcannot both be provided (prevents confusion)Added new test (
test_runner_init_allows_app_name_override_with_app):app_namecan overrideapp.namewhen both are providedrunner.app_name == "override_name"whilerunner.appstill references the original App objecttests/unittests/test_runners.py::TestRunnerWithPlugins::test_runner_init_allows_app_name_override_with_app PASSED [100%]
tests/unittests/test_runners.py::TestRunnerWithPlugins::test_runner_init_raises_error_with_app_and_agent PASSED [100%]
Manual End-to-End (E2E) Tests:
Expected Results:
appandapp_nameprovidedrunner.app_nameequals the providedapp_name(notapp.name)app_nameChecklist
Additional context
Backward Compatibility:
This change is fully backward compatible. All existing code patterns continue to work:
Runner(app=my_app)→ Still usesapp.nameRunner(app_name="x", agent=my_agent)→ Still worksRunner(app=my_app, app_name=None)→ Still works (usesapp.name)Impact on Agent Engine:
This change enables Agent Engine deployments to support event compaction and context caching. Once this PR is merged, Agent Engine SDK should:
Appobjects fromAdkApp(app=my_app, ...)Runnerwith bothappandapp_name(resource name):Related Documentation:
src/google/adk/apps/compaction.pysrc/google/adk/agents/context_cache_config.pysrc/google/adk/runners.py