-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix: Add missing space in README.md #3939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @hiroakis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a minor formatting issue within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a minor formatting issue in the README.md file by adding a missing space after a markdown link. The change is correct and improves the readability of the document. The fix is well-contained and I see no other issues.
Merge #3939 ### Link to Issue or Description of Change **1. Link to an existing issue (if applicable):** n/a **2. Or, if no issue exists, describe the change:** **Problem:** In the Community Repo section of README.md, there was a missing space between the markdown link `[adk-python-community repo](...)` and the word `that`, causing the text to render as `repo](...)that` instead of `repo](...) that`. **Solution:** Add a single space between the closing parenthesis of the markdown link and the word "that" to fix the typo. ### Testing Plan **Unit Tests:** This is a small documentation/typo fix. No code changes were made. **Manual End-to-End (E2E) Tests:** I verified that the markdown renders correctly with proper spacing between the link and following text. ### Checklist - [x] I have read the [CONTRIBUTING.md](https://github.com/google/adk-python/blob/main/CONTRIBUTING.md) document. - [x] I have performed a self-review of my own code. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have added tests that prove my fix is effective or that my feature works. - [x] New and existing unit tests pass locally with my changes. - [x] I have manually tested my changes end-to-end. - [x] Any dependent changes have been merged and published in downstream modules. ### Additional context This is a minor typo fix in the README.md file. No functional changes. Co-authored-by: Xiang (Sean) Zhou <seanzhougoogle@google.com> COPYBARA_INTEGRATE_REVIEW=#3939 from hiroakis:fix-readme-typo f4e8014 PiperOrigin-RevId: 845595505
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
n/a
2. Or, if no issue exists, describe the change:
Problem:
In the Community Repo section of README.md, there was a missing space between the markdown link
[adk-python-community repo](...)and the wordthat, causing the text to render asrepo](...)thatinstead ofrepo](...) that.Solution:
Add a single space between the closing parenthesis of the markdown link and the word "that" to fix the typo.
Testing Plan
Unit Tests:
This is a small documentation/typo fix. No code changes were made.
Manual End-to-End (E2E) Tests:
I verified that the markdown renders correctly with proper spacing between the link and following text.
Checklist
Additional context
This is a minor typo fix in the README.md file. No functional changes.