feat(tools):exposed configurable parameter as property in McpToolset

[DineshThumma9]

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

• Closes: Missing public properties in McpToolset #4270

Problem:
When using MCP tools with McpToolset, configuration information for the object is not exposed as object properties or attributes meaning that 'private' attributes need to be accessed, e.g. toolset._connection_params rather than toolset.connection_params

Solution:
Exposed them as properties

Testing Plan

Unit Tests:

• I have added or updated unit tests for my change.
• All unit tests pass locally.

Manual End-to-End (E2E) Tests:

I have added new test cases also checked locally

Checklist

• I have read the CONTRIBUTING.md document.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have added tests that prove my fix is effective or that my feature works.
• New and existing unit tests pass locally with my changes.
• I have manually tested my changes end-to-end.
• Any dependent changes have been merged and published in downstream modules.

Additional context

[gemini-code-assist]

Summary of Changes

Hello @DineshThumma9, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the McpToolset class by transforming several internal configuration attributes into public properties. This modification provides a standardized and more Pythonic way to access these settings, enhancing the object's interface and reducing reliance on direct access to private members. The change aims to improve the overall usability and maintainability of the McpToolset by promoting better encapsulation.

Highlights

• Enhanced McpToolset Usability: The McpToolset class now exposes several previously internal configuration parameters as public properties, improving accessibility and adhering to Pythonic encapsulation principles.
• New Public Properties: Added @property decorators for connection_params, auth_scheme, auth_credential, require_confirmation, header_provider, and errlog to allow direct access to these configurations.
• Improved Code Maintainability: This change eliminates the need to access 'private' attributes (e.g., _connection_params) directly, making the code cleaner and less prone to errors when interacting with McpToolset.
• Comprehensive Unit Testing: New unit tests have been added to test_mcp_toolset.py to ensure the correct functionality and behavior of all newly exposed properties.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request exposes several configuration parameters of McpToolset as public, read-only properties, which is a good improvement to avoid accessing private attributes. The changes look good overall. I've added a couple of suggestions: one to improve the formatting of a property definition for better readability and another to refactor a unit test to align with best practices by testing the public API instead of internal implementation details.

[gemini-code-assist]

The formatting of this property definition is unconventional. It's more standard to keep self on the same line as the method name. If the line length is an issue, you can break the type hint across multiple lines for better readability.

  def header_provider(self) -> Optional[Callable[[ReadonlyContext], Dict[str, str]]]: