fix(interactions/events):fixed response duplication and added turn_complete check to is_final_response()

[DineshThumma9]

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

• Closes: Response streaming broken after migration to Gemini Interactions API #4384

2. Or, if no issue exists, describe the change:

Problem:
After Migration to interactions response was getting duplicated and also is_final_response isn't using turn complete for deciding final response

Solution:
Removed aggregated message as interaction.update was taking care of final response and added turn_complete to is_final_response()

Testing Plan

Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.

Unit Tests:

• I have added or updated unit tests for my change.
• All unit tests pass locally.

Please include a summary of passed pytest results.

Manual End-to-End (E2E) Tests:

Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.

Checklist

• I have read the CONTRIBUTING.md document.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have added tests that prove my fix is effective or that my feature works.
• New and existing unit tests pass locally with my changes.
• I have manually tested my changes end-to-end.
• Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

[gemini-code-assist]

Summary of Changes

Hello @DineshThumma9, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses critical issues related to response handling in the interactions module. It resolves a problem where responses were being duplicated after a migration to interactions by removing an unnecessary aggregated response generation step. Additionally, it refines the logic for determining a final response by incorporating a turn_complete check, ensuring more accurate and singular final response identification.

Highlights

• Response Duplication Fix: Eliminated redundant final aggregated response generation in streaming interactions, as the interaction.update mechanism now correctly handles the final response, preventing duplicate outputs.
• is_final_response Logic Update: Modified the is_final_response method to explicitly check for self.turn_complete, ensuring that a response is only considered final when the entire turn is complete, alongside other existing conditions.
• New Unit Tests: Introduced new unit tests to validate the updated is_final_response logic, specifically confirming its reliance on turn_complete, and to verify that streaming interactions do not produce duplicate final responses.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/google/adk/events/event.py
  • Added self.turn_complete as a condition for is_final_response() to return True.
• src/google/adk/models/interactions_utils.py
  • Removed the code block responsible for yielding a "Final aggregated response" as interaction.update now manages this.
• tests/unittests/models/test_interactions_utils.py
  • Added TestResponseInteractionDeduplication class with tests:
  • test_is_final_response_requires_turn_complete_true: Verifies is_final_response() correctly uses the turn_complete flag.
  • test_no_duplicate_final_response_in_streaming: Confirms that streaming interactions produce only one final response.

Activity

• Linked to issue Response streaming broken after migration to Gemini Interactions API #4384.
• Provided a detailed problem description: response duplication post-migration and is_final_response not using turn_complete.
• Outlined the solution: removed aggregated message and added turn_complete to is_final_response().
• Confirmed that unit tests were added/updated and pass locally.
• Completed a self-review, commented code, and added tests as per the contribution checklist.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses the response duplication issue in streaming mode and corrects the logic for is_final_response(). The changes are clear and well-supported by the new unit tests. I've left a couple of minor suggestions in the test file to improve code style by moving local imports to the top level.

[DineshThumma9]

/gemini review

[gemini-code-assist]

Code Review

This pull request addresses response duplication and improves the final response detection when using the interactions API. The changes correctly incorporate the turn_complete flag in is_final_response() and remove logic that caused duplicate final messages. The accompanying unit tests are well-designed to cover these fixes. I've identified a critical issue with a missing import in the new tests that will prevent them from running, and a minor maintainability issue with a redundant import. My comments provide details on how to resolve these.

[DineshThumma9]

/gemini review

[gemini-code-assist]

Code Review

This pull request addresses an issue with response duplication in streaming mode when using the interactions API. The fix involves removing a redundant final response yield and correctly using the turn_complete flag in is_final_response(). The changes are logical and well-supported by new unit tests that verify the fix. Overall, this is a good change. I have one suggestion to refactor one of the new tests to be more concise and maintainable using pytest.mark.parametrize.