fix(web): avoid eval history crash when toolUses is null#4660
Open
pandego wants to merge 1 commit intogoogle:mainfrom
Open
fix(web): avoid eval history crash when toolUses is null#4660pandego wants to merge 1 commit intogoogle:mainfrom
pandego wants to merge 1 commit intogoogle:mainfrom
Conversation
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
Problem:
Failed eval history entries can crash the web UI when
intermediateData.toolUsesis missing/null.formatToolUsescurrently iterates directly over that value and throwsTypeError: e is not iterable.Solution:
Add a null guard in
formatToolUsesso missingtoolUsesis treated as an empty list.Testing Plan
Unit Tests:
Passed locally:
.venv/bin/pytest tests/unittests/evaluation/test_eval_config.py7 passedManual End-to-End (E2E) Tests:
Not run in this environment. This patch is a minimal defensive guard on the affected formatter path.
Checklist
Additional context
This is intentionally minimal (1-line behavior change) to reduce risk and keep review focused.