Fix sub-agent premature termination in LRO tool flow (Issue #5349)#5384
Draft
9chait9 wants to merge 1 commit intogoogle:mainfrom
Draft
Fix sub-agent premature termination in LRO tool flow (Issue #5349)#53849chait9 wants to merge 1 commit intogoogle:mainfrom
9chait9 wants to merge 1 commit intogoogle:mainfrom
Conversation
…ool. Fixes google#5349 - Track sub-agent pause state during resumption. - Only mark as finished if the sub-agent did not pause.
adk-bot
added
the
core
Collaborator
|
Response from ADK Triaging Agent Hello @9chait9, thank you for creating this PR! Could you please add a In addition, could you please provide logs or screenshot after the fix is applied? This information will help reviewers to review your PR more efficiently. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5349
The issue occurred because the orchestrator unconditionally marked a sub-agent as
end_of_agent=Trueafter resumption, even if it had paused for another long-running operation (LRO).This change tracks the pause state of the sub-agent during resumption and only marks the agent as finished if it did not pause.
Summary of changes:
_run_async_implinsrc/google/adk/agents/llm_agent.pyto tracksub_agent_pausedstate.ctx.set_agent_state(self.name, end_of_agent=True)ifsub_agent_pausedis false.