fix(tools): handle tuple schemas in function parsing fallback#5429
Open
kaligautier wants to merge 1 commit intogoogle:mainfrom
Open
fix(tools): handle tuple schemas in function parsing fallback#5429kaligautier wants to merge 1 commit intogoogle:mainfrom
kaligautier wants to merge 1 commit intogoogle:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
list[tuple[bytes, str]]parameter type #54282. Or, if no issue exists, describe the change:
N/A (issue exists).
Problem:
FunctionToolautomatic declaration parsing crashes when a parameter useslist[tuple[bytes, str]] | None. The fallback path relies on Pydantic schemaoutput, but
google.genai.types.Schemarejects tupleprefixItems, causing astartup failure.
Solution:
Normalize tuple-related JSON Schema output in the fallback parser before
validation by
types.Schema:prefixItemsto a supported shape (items.anyOf)unevaluatedItems,items: false)list[tuple[bytes, str]] | NoneTesting Plan
Unit Tests:
Passed locally:
uv run --with pytest --with pytest-asyncio pytest tests/unittests/tools/test_from_function_with_options.py -q→17 passeduv run --with pytest --with pytest-asyncio pytest tests/unittests/tools/test_build_function_declaration.py tests/unittests/tools/test_function_tool.py tests/unittests/tools/test_from_function_with_options.py -q→83 passedManual End-to-End (E2E) Tests:
Manual validation using the issue repro signature:
from_function_with_optionswithinput_bytes: list[tuple[bytes, str]] | Nonecomputed correctly, and the optional tuple parameter remains nullable.
Checklist
Additional context
This fix intentionally targets schema compatibility in the legacy automatic
function declaration fallback path without changing tool behavior.