fix(agents): add missing BaseLlm import to prevent NameError in sub-agents#5443
Open
EaCognitive wants to merge 3 commits intogoogle:mainfrom
Open
fix(agents): add missing BaseLlm import to prevent NameError in sub-agents#5443EaCognitive wants to merge 3 commits intogoogle:mainfrom
EaCognitive wants to merge 3 commits intogoogle:mainfrom
Conversation
adk-bot
added
the
core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2082
Problem
In
LlmAgent.canonical_model, there is a checkisinstance(self.model, BaseLlm). However,BaseLlmis not imported in the module, leading to aNameErrorat runtime when an agent attempts to resolve its model. This is particularly critical in sub-agent scenarios where model inheritance is common.Solution
Added the missing
BaseLlmimport from..models.base_llm.Verification
Verified that the import is present and resolves correctly.