fix(firestore): preserve update timestamps in list_sessions#5640
Open
kkj333 wants to merge 1 commit intogoogle:mainfrom
Open
fix(firestore): preserve update timestamps in list_sessions#5640kkj333 wants to merge 1 commit intogoogle:mainfrom
kkj333 wants to merge 1 commit intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Populate Session.last_update_time from Firestore updateTime in list_sessions so session listings report accurate timestamps instead of always returning 0.0.
0a94def to
a9d4a60
Compare
Author
|
The failing check is caused by the triaging workflow configuration, not by this PR changes.
Could a maintainer please update the triaging agent model (or rerun after fixing the workflow config)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
Closes: #5632
Problem
FirestoreSessionService.list_sessions()always setsSession.last_update_timeto0.0, even when Firestore documents containupdateTime.Solution
Use the same timestamp conversion logic as
get_session()inlist_sessions():updateTimeis adatetime, use.timestamp()float(updateTime)0.0when conversion failsThis keeps list responses consistent with
get_session()and preserves accurate update timestamps.Testing Plan
Unit Tests:
Updated tests:
test_list_sessions_with_user_idtest_list_sessions_without_user_idLocal pytest summary:
tests/unittests/integrations/firestore/test_firestore_session_service.py17 passedManual End-to-End (E2E) Tests:
Reproduced with a mocked Firestore client where session docs include
updateTime; before fixlast_update_timewas0.0, after fix it matches the Firestore value.Checklist