Skip to content

fix(sessions): return empty events when num_recent_events=0 in DatabaseSessionService #5736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mangod12 wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −1
Open

fix(sessions): return empty events when num_recent_events=0 in DatabaseSessionService #5736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
451cd07
fix(sessions): return empty events when num_recent_events=0 in Databa…
mangod12 May 18, 2026
f18250b
chore: retrigger CI after CLA signing
mangod12 May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/google/adk/sessions/database_session_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,7 @@ async def get_session(

stmt = stmt.order_by(schema.StorageEvent.timestamp.desc())

if config and config.num_recent_events:
if config and config.num_recent_events is not None:
stmt = stmt.limit(config.num_recent_events)

result = await sql_session.execute(stmt)
Expand Down
7 changes: 7 additions & 0 deletions tests/unittests/sessions/test_session_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1057,6 +1057,13 @@ async def test_get_session_with_config(session_service):
events = session.events
assert len(events) == num_test_events

# num_recent_events=0 should return no events.
config = GetSessionConfig(num_recent_events=0)
session = await session_service.get_session(
app_name=app_name, user_id=user_id, session_id=session.id, config=config
)
assert len(session.events) == 0

# Only expect the most recent 3 events.
num_recent_events = 3
config = GetSessionConfig(num_recent_events=num_recent_events)
Expand Down