Skip to content

Console refractory and testing#431

Merged
Lencerf merged 2 commits intogoogle:mainfrom
Lencerf:refactor/console/split
Mar 13, 2026
Merged

Console refractory and testing#431
Lencerf merged 2 commits intogoogle:mainfrom
Lencerf:refactor/console/split

Conversation

@Lencerf
Copy link
Collaborator

@Lencerf Lencerf commented Mar 13, 2026

No description provided.

@coveralls
Copy link

coveralls commented Mar 13, 2026

Pull Request Test Coverage Report for Build 23068039308

Details

  • 28 of 62 (45.16%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.8%) to 27.734%

Changes Missing Coverage Covered Lines Changed/Added Lines %
alioth/src/device/pl011.rs 8 10 80.0%
alioth/src/vm/vm.rs 0 4 0.0%
alioth/src/device/serial.rs 0 5 0.0%
alioth/src/device/console.rs 20 43 46.51%
Files with Coverage Reduction New Missed Lines %
alioth/src/device/console.rs 2 45.26%
Totals Coverage Status
Change from base Build 22988765517: 0.8%
Covered Lines: 4013
Relevant Lines: 14877

💛 - Coveralls

@Lencerf Lencerf force-pushed the refactor/console/split branch 2 times, most recently from c7d258c to 6e079ff Compare March 13, 2026 18:16
Decouple the console worker thread from hardcoded stdio logic by
introducing a generic Console trait. This enables support for
multiple backends (e.g., StdioConsole, TestConsole) and moves
terminal state management (termios) into the stdio implementation.

Signed-off-by: Changyuan Lyu <changyuanl@google.com>
@Lencerf Lencerf force-pushed the refactor/console/split branch from 2932db8 to ebb3617 Compare March 13, 2026 19:44
Signed-off-by: Changyuan Lyu <changyuanl@google.com>
@Lencerf Lencerf marked this pull request as ready for review March 13, 2026 20:02
@Lencerf Lencerf merged commit 02504ad into google:main Mar 13, 2026
5 checks passed
@Lencerf Lencerf deleted the refactor/console/split branch March 13, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants