Relax checks on signed_attrs #239
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This crate has some checks on signed attributes that are much stricter than what is required by windows. For instance: 1. Windows accepts having no signed attributes. In this case, it assumes the signature is done over the embedded message data instead of the signed attributes. 2. Windows accepts a signed-attributes with no content-type attr. In fact, it even accepts one with an invalid/mismatched content-type - it looks like windows completely ignores that attribute. The only check really necessary is that, if signed attributes _are_ present, it must contain a message-digest attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crate has some checks on signed attributes that are much stricter than what is required by windows. For instance:
Windows accepts having no signed attributes. In this case, it assumes the signature is done over the embedded message data instead of the signed attributes.
Windows accepts a signed-attributes with no content-type attr. In fact, it even accepts one with an invalid/mismatched content-type - it looks like windows completely ignores that attribute.
The only check really necessary is that, if signed attributes are present, it must contain a message-digest attribute.
Fixes #238
Fixes #237