constructSubjectClause, constructPredicateClause and constructObjectClause #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xllora
reviewed
May 24, 2017
|
|
||
| // constructSubjectClause returns an element hook that updates the subject | ||
| // modifiers on the working construct clause. | ||
| func constructSubjectClause() ElementHook { |
Member
There was a problem hiding this comment.
Would you mind add tests for the next functions being added here?
…cateClause and constructObjectClause
Contributor
Author
|
I have rebased this branch off of master to incorporate the bug fix for issue 70 + added tests. PTAL, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have not added any tests yet. If this commit looks good on a high level, I will add tests before merging this branch.