_ReadWriteBarrier() is deprecated in MSVC 2015 (possibly earlier)

[staffantj]

With the library being rebased on C++11, we should be using std::atomic_thread_fence instead per https://docs.microsoft.com/en-us/cpp/intrinsics/readwritebarrier?view=vs-2015

On the assumption that the fence is only being used to prevent read/write re-ordering, it should be sufficient / equivalent to use std::memory_order_acq_rel.

[LebedevRI]

Would be good to provide more complete error message.
Can you link to the line where _ReadWriteFence is used?
I do not find anything:

googlebenchmark$ grep -r _ReadWriteFence
$

[staffantj]

Apologies, I typo'd the subject, hopefully fixed now.

It occurs at, for instance, in master:

benchmark/include/benchmark/benchmark.h

Line 337 in 4528c76

_ReadWriteBarrier();

There's no compiler error / warning message that I've seen, merely the documentation on the microsoft site, I came across the issue whilst looking at gcc / msvc differences for an in-house documentation effort.