Supply MacOS deployment target to delocate, use build+uv frontend#1841
Closed
nicholasjng wants to merge 1 commit intogoogle:mainfrom
Closed
Supply MacOS deployment target to delocate, use build+uv frontend#1841nicholasjng wants to merge 1 commit intogoogle:mainfrom
nicholasjng wants to merge 1 commit intogoogle:mainfrom
Conversation
This shaves off multiple minutes from the wheel builds alone. Also revert to trusted publishing for wheel uploads as it is now set up.
dmah42
approved these changes
Aug 20, 2024
Contributor
Author
|
Hm, I have no idea what's going wrong here - builds perfectly fine on my local laptop (MacOS ARM64). I will investigate. |
Contributor
Author
|
Ah, it's related to the use of Python 3.11. The problem disappears when building with Python 3.12. I wonder if that's because of the removal of distutils? EDIT: It's a failure in setuptools v73.0.0, which was released yesterday - that's why CI on main is green. Will update the requirements constraints asap. |
Contributor
Author
|
Closing in favor of the follow-up PR containing the setuptools-scm revert, which is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shaves off multiple minutes from the wheel builds alone.
Also revert to trusted publishing for wheel uploads as it is now set up.
This limits Google Benchmark PyPI distributions to Python 3.10+.
Successful wheel build run on this branch: https://github.com/nicholasjng/benchmark/actions/runs/10452277981 , slightly under 20 minutes elapsed time including aarch64.