Closed
Conversation
|
❌ Build benchmark 369 failed (commit d76dadde74 by @EricWF) |
|
❌ Build benchmark 374 failed (commit 83342ddc26 by @EricWF) |
|
✅ Build benchmark 376 completed (commit a95703ca99 by @EricWF) |
Contributor
|
FWIW I like this API much better. No time to look at #262 tonight though. |
Contributor
Author
|
Abandoning since this was only ever meant as an example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@biojppm I took the liberty of implementing a version of your patch with the interface I would like to see. Please take a look at this PR, in particular the removal of
BenchmarkCountersand the changes toCounter.@biojppm I don't want to hijack your pull request, I just wanted you to see the interface I had in mind.