Refactor output test runner into standalone module.#277
Refactor output test runner into standalone module.#277EricWF merged 8 commits intogoogle:masterfrom
Conversation
|
❌ Build benchmark 370 failed (commit f96d0d647b by @EricWF) |
|
❌ Build benchmark 371 failed (commit eef9b59d3f by @EricWF) |
|
❌ Build benchmark 372 failed (commit cb64c59b21 by @EricWF) |
|
❌ Build benchmark 373 failed (commit 1975afc95e by @EricWF) |
|
✅ Build benchmark 375 completed (commit 47efba584b by @EricWF) |
|
✅ Build benchmark 377 completed (commit ea906a9f41 by @EricWF) |
test/output_test.h
Outdated
|
|
||
| namespace { | ||
|
|
||
| std::string dec_re = "[0-9]*[.]?[0-9]+([eE][-+][0-9]+)?"; |
There was a problem hiding this comment.
a static non-pod defined in a header? say it ain't so!
this should probably be
extern const char* const dec_re;
and then in the .cc
const char* const dec_re = "...";
There was a problem hiding this comment.
The non-pod part is definitely an issue, but static initialization is safer if the initializer is in the header so the compiler can see it.
|
so much cleaner :) |
5 participants
I plan to commit this without review. I just want to make sure the bots handle it first.