Supply old RangePair and ArgPair API for C++03 compatibility.#278
Merged
dmah42 merged 8 commits intogoogle:masterfrom Aug 29, 2016
Merged
Supply old RangePair and ArgPair API for C++03 compatibility.#278dmah42 merged 8 commits intogoogle:masterfrom
RangePair and ArgPair API for C++03 compatibility.#278dmah42 merged 8 commits intogoogle:masterfrom
Conversation
|
❌ Build benchmark 383 failed (commit c562760de4 by @EricWF) |
|
❌ Build benchmark 390 failed (commit dd76817db3 by @EricWF) |
|
❌ Build benchmark 394 failed (commit 47edc4be5c by @EricWF) |
| // Equivalent to Args({x, y}) | ||
| // NOTE: This is a legacy C++03 interface provided for compatibility only. | ||
| // New code should use 'Args'. | ||
| Benchmark* ArgPair(int x, int y) { |
Member
There was a problem hiding this comment.
should we also mark these as deprecated?
Contributor
Author
There was a problem hiding this comment.
I don't think so. Using the replacements requires C++11. So if you want C++03 benchmarks you still need this interface.
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new
RangesandArgsinterface requires C++11 initializer lists to be useful. In C++03 the new interface is almost impossible to use. This patch re-adds the old C++03 interface for continued compatibility.Additionally this patch re-adds the
range_x()andrange_y()methods but marks them as deprecated. This should allow older benchmarks to continue to compile while making it clear that this interface is deprecated.The final change in this patch gives
ranges(pos)the default argument0allowingranges()to work. This seems like a convenience to me but I"m happy to remove it.