Cleanup test/CMakeLists.txt#558
Closed
EricWF wants to merge 1 commit intogoogle:masterfrom
Closed
Conversation
Contributor
Author
|
Just creating the PR to cycle the bots. |
EricWF
force-pushed
the
cleanup-cmake-for-tests
branch
from
913358b to
7affedc
Compare
This patch attempts to cleanup and reduce duplication in the CMake which builds and registers the tests. The patch adds a `add_benchmark_test` CMake function with a number of options; allowing almost all tests to use it directly.
EricWF
force-pushed
the
cleanup-cmake-for-tests
branch
from
7affedc to
72cfb60
Compare
|
✅ Build benchmark 1148 completed (commit 7c8bbc574e by @EricWF) |
|
✅ Build benchmark 1150 completed (commit ddf49fd9b9 by @EricWF) |
Member
|
Is this still something you want to pursue @EricWF ? |
Member
|
ping @EricWF |
Member
|
ping :) |
Member
|
treating this as abandoned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch attempts to cleanup and reduce duplication in the CMake
which builds and registers the tests.
The patch adds a
add_benchmark_testCMake function with a numberof options; allowing almost all tests to use it directly.