Run git from the source directory (#589)#590
Merged
dmah42 merged 1 commit intogoogle:masterfrom May 8, 2018
php1ic:fix-GetGitVersion
Merged
Run git from the source directory (#589)#590dmah42 merged 1 commit intogoogle:masterfrom php1ic:fix-GetGitVersion
dmah42 merged 1 commit intogoogle:masterfrom
php1ic:fix-GetGitVersion
Conversation
Git was being executed in the current directory, so could not get the latest tag if cmake was run from a build directory. Force git to be run from with the source directory.
|
✅ Build benchmark 1216 completed (commit 7ed1818809 by @php1ic) |
Member
|
that's odd... i've been running cmake from a build directory for ever: and it was working fine. I don't think this breaks anything, but i'm curious what other differences you might have on your platform. |
Member
|
oh i see.. your build directory is parallel to the source directory :) |
JBakamovic
pushed a commit
to JBakamovic/benchmark
that referenced
this pull request
Dec 6, 2018
Git was being executed in the current directory, so could not get the latest tag if cmake was run from a build directory. Force git to be run from with the source directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Git was being executed in the current directory, so could not get the
latest tag if cmake was run from a build directory. Force git to be
run from with the source directory.