Skip to content

removed locked notify_all() call.#662

Closed
GevArakelyan wants to merge 1 commit intogoogle:masterfrom
GevArakelyan:master
Closed

removed locked notify_all() call.#662
GevArakelyan wants to merge 1 commit intogoogle:masterfrom
GevArakelyan:master

Conversation

@GevArakelyan
Copy link
Copy Markdown

I'm not an expert but as far as i know when conditional variable notify_all() function is called it's discouraged to lock the mutex at the same time.

When conditional variable notify_all() function is called it's bad idea to lock the mutex at the same time.
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@AppVeyorBot
Copy link
Copy Markdown

Build benchmark 1388 failed (commit 8226d5c726 by @GevArakelyan)

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.008%) to 86.869% when pulling 1857756 on GevArakelyan:master into af441fc on google:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants