Merged
Conversation
3 tasks
|
✅ Build benchmark 1575 completed (commit 29b778268a by @Croydon) |
uilianries
reviewed
Dec 10, 2018
uilianries
reviewed
Dec 10, 2018
uilianries
reviewed
Dec 10, 2018
uilianries
reviewed
Dec 10, 2018
danimtb
reviewed
Dec 10, 2018
eb57359 to
bf88397
Compare
Contributor
Author
|
I have actually reconsidered and removed Please review this @dominichamon |
danimtb
approved these changes
Dec 17, 2018
uilianries
approved these changes
Dec 17, 2018
Member
|
Thank you all! |
This was referenced Jan 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is split from #647
It only contains the minimum changes to get initial Conan support.
With this changes you can create a Conan package by executing
conan create . benchmark/<version-number>@google/stableor better: to actual test if the package works, the test_package should be executed with it:
conan create . benchmark/<version-number>@google/stable -tf conan/test_package(the parameter
tfstands for test folder).If no error appears the created Benchmark Conan package can be consumed by projects locally.
This does NOT contain any kind of publishing/uploading mechanism with mass building for different configurations/operating systems etc. this should be eventually done via #647
cc @memsharded @dominichamon