Remove unused doc argument from DEFINE_ macros.#857
Merged
dmah42 merged 1 commit intogoogle:masterfrom Aug 21, 2019
Merged
Conversation
- Adresses : google#856 - The unused `doc` argument was removed from the `DEFINE_` macros in `commandlineflags.h` - Converted all the previous `doc` strings passed to the `DEFINE_` macros to multiline comments.
Member
|
Thanks! |
JBakamovic
pushed a commit
to JBakamovic/benchmark
that referenced
this pull request
Sep 11, 2020
- Adresses : google#856 - The unused `doc` argument was removed from the `DEFINE_` macros in `commandlineflags.h` - Converted all the previous `doc` strings passed to the `DEFINE_` macros to multiline comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adresses : Remove unused
docargument fromDEFINE_<data_type>(name, default_val, doc)macros. #856The unused
docargument was removed from theDEFINE_macros incommandlineflags.hConverted all the previous
docstrings passed to theDEFINE_macros to multiline comments.