Hide flyout after Events are re-enabled when creating a block#4055
Merged
Conversation
rachel-fenichel
approved these changes
Jul 21, 2020
rachel-fenichel
left a comment
rachel-fenichel
left a comment
Collaborator
There was a problem hiding this comment.
Seems reasonable, and I have no memory of why it was inside the try.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
#4034
Proposed Changes
Hide flyout after events are re-enabled when creating a block from the flyout.
Reason for Changes
Allows for the category event for a flyout category closing to be triggered, making events for category open/close more consistent.
Test Coverage
Tested manually in playground by observing events logged.
Tested on:
Additional Information
The logic for hiding the flyout while Events are disabled was introduced in #1078.
This doesn't appear to cause any unintended side effects.