Emitting event on trashcan close.#4056
Merged
moniika merged 2 commits intoJul 21, 2020
Merged
Conversation
rachel-fenichel
approved these changes
Jul 21, 2020
rachel-fenichel
left a comment
rachel-fenichel
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, though I have one comment on naming.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
#4033
Proposed Changes
Adds logic for emitting event when trashcan is closed and adds helper for opening/closing trashcan flyout.
Reason for Changes
Adding helpers makes the connection between showing/hiding flyout and emitting event for open/close clearer.
Event for closing trashcan flyout is consistent with behavior of other similarly named Ui events.
Test Coverage
Tested on playground by observing event logging.
Tested on:
Additional Information
The change in #4034 in combination with this change will cause event to be emitted when block is dragged out of trashcan flyout.